Note: If you make pull requests from non-master branches then you can git push -f to update them in-place.

@adamv: If I use -f doesn't that squash all the comments on the commit?

It does a force push, you still have to squash with git rebase -i <target>

Sorry, I meant to ask, "if I use -f, doesn't it cause the conversation surrounding the proposed commit (i.e., "is 'rlwrap' really a hard dependency?") to get removed?"

Oh, well I guess GitHub has some issues in that regard, but it is preferable to lose comments than get new pull requests for every edit.

Fair enough. I'll keep that in mind for next time, thanks!

On Fri, Feb 22, 2013 at 9:45 AM, Adam Vandenberg
notifications@github.comwrote:

Oh, well I guess GitHub has some issues in that regard, but it is
preferable to lose comments than get new pull requests for every edit.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/18010#issuecomment-13957798.

Thanks,
Weiser

Do I need to do anything more to get this PR merged?

Should rlwrap be optional?

Are you Ok if I make it recommended, or do you really want it to be optional?

My 2c as a (so far) only very casual Clojure user: I started using rlwrap with it almost immediately when I got started, as it was quite painful to use without. Lack of readline in any REPL feels like a killer.

As long as there are no serious concerns about the readline dependency causing problems (seems like it's keg-only to limit it stomping on the OS defaults?) I'd definitely +1 making it recommended instead of optional.

I agree with @bitprophet. To put things in perspective, with Leiningen and its built-in REPL the standard Clojure REPL is not very useful but it's a welcome improvement for beginners who don't know about Leiningen yet.

Can we get this squash to a single commit and rebased on master? Thanks.